fix: added extra security measure for ERC20/ERC721 contracts #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvibes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses security vulnerabilities and adds security measures to both the ERC20 and ERC721 contracts. Below is a summary of the changes i made:
Changes made:
ERC20 Contract:
Added: onlyOwner modifier to restrict minting and burning functions to the contract owner.
Refactored: The transferFrom function to ensure balance checks and proper authorization.
ERC721 Contract:
Added: require check to certain functions to enhance security.
Refactored: ensuring only the owner can mint new tokens.